Skip to content

feat: Added Dify template #3074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Conversation

OhThatMatt
Copy link
Contributor

@OhThatMatt OhThatMatt commented Aug 13, 2024

I've added a template for Dify, but I'm running into couple of issues.

  1. Postgres Password/User Generation:
  • I'm having trouble generating the Postgres password and user. When attempting to do this with $SERVICE, it messes up other parts of the configuration, leading to issues where the credentials cannot be found.
  1. API Server Name Issue:
  • The API server is currently appearing as a random string. It needs to be set in the ENV variables, but it has to match the public URL.
  1. Health Checks on Services:
  • Health checking is not implemented for all services, resulting in some containers reporting as unhealthy, even though they are functioning correctly.
  1. Redis Service Variables:
  • The SERVICE_USER_REDIS and SERVICE_PASSWORD_REDIS variables are defaulting to blank strings during deployments. Despite being set and visible in the ENV variables, they cannot be found during deployment.

Dify supports a variety of vector databases, and you can change them by setting an environment variable. However, this approach causes problems because each container is still created regardless of the ENV variable, leading to deployment failures. As a workaround, I removed all but the default database. I’m open to suggestions on a better way to handle this.

The original docker-compose can be found here: docker-compose.yaml

@OhThatMatt OhThatMatt marked this pull request as draft August 14, 2024 07:19
@OhThatMatt OhThatMatt changed the title feat: Add Dify feat: Added Dify template Aug 14, 2024
@OhThatMatt OhThatMatt changed the base branch from main to next August 14, 2024 15:41
@OhThatMatt
Copy link
Contributor Author

OhThatMatt commented Aug 14, 2024

Updated the commit with improvements on the original PR.

On the first install you will be prompted to enter an init password which can be found in the env variables.

@OhThatMatt OhThatMatt marked this pull request as ready for review August 14, 2024 18:41
@andrasbacsai andrasbacsai added the ⚙️ Service Issues requesting or PRs adding/fixing service templates. label Aug 27, 2024
Copy link

gitguardian bot commented Sep 19, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@rennokki
Copy link
Contributor

rennokki commented Oct 4, 2024

LGTM!

@github-actions github-actions bot removed the ⚙️ Service Issues requesting or PRs adding/fixing service templates. label Oct 4, 2024
@lei-cao
Copy link

lei-cao commented Oct 4, 2024

wow! when will this be released?

@OhThatMatt
Copy link
Contributor Author

@lei-cao

The other PR for AI related templates has been merged yesterday (#2980) I hope that this one will get reviewed soon.

@rennokki
Copy link
Contributor

rennokki commented Oct 5, 2024

@andrasbacsai

@peaklabs-dev peaklabs-dev added the ⚙️ Service Issues requesting or PRs adding/fixing service templates. label Oct 9, 2024
@peaklabs-dev peaklabs-dev changed the base branch from next to next-save October 10, 2024 15:33
@peaklabs-dev
Copy link
Member

Thank you for the PR 💜. I will test it and fix it if necessary.

@peaklabs-dev peaklabs-dev merged commit c2f1f4a into coollabsio:next-save Oct 10, 2024
1 check passed
@github-actions github-actions bot removed the ⚙️ Service Issues requesting or PRs adding/fixing service templates. label Oct 10, 2024
@ekiwi111
Copy link

ekiwi111 commented Nov 9, 2024

I'm getting a 404 error from /console/api/setup on the /install page when running Dify with the Docker Compose template. Is there any additional configuration I need to add?

@Deyvi-dev
Copy link

Deyvi-dev commented Nov 14, 2024

@OhThatMatt I noticed that the Dify template was added in release v4.0.0-beta.361; however, it’s missing from the templates/service-templates.json file.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants