-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add edgedb configuration #2058
feat: add edgedb configuration #2058
Conversation
edgedb.svg includes EdgeDB logo and add edgedb.yaml the configuration for edgedb and postgres services. Commit includes setting environment variables, volumes, health checks, and ports.
@andrasbacsai Any chance you could have a look at this? |
any updates on this? |
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
Would love this |
Thanks for the PR, this needs to be added to the codebase as a DB (I will leave this open for now). |
@peaklabs-dev Sounds good! I've understood quite a bit more since April when this was made, so there's probably much to improve here. Meanwhile I've been using Ports Mapping to bypass Traefik all-together, due to running into issues there. I would love to get this nailed down on Coolify, as it's truly not straightforward at the moment. Some worthy discussions regarding EdgeDB and Traefik:
Additionally, EdgeDB runs on PostgreSQL, so Coolify's existing backups work, but if anyhow possible, EdgeDB's own dump would be just excellent to have. |
Thanks for the PR. Databases should not be added as service templates, they need to be added differently to the codebase. You can search for |
The way this is set up isn't really a new database, it's postgres with a frontend. |
Oh I see. I will add this then. Thank you for the PR. I will test it and fix it if necessary. |
EdgeDB has a launch week and it's reaching 5.0, so it feels like a good time to add it (back) to Coolify.
This PR includes EdgeDB logo and adds the edgedb.yaml, which includes setting environment the variables, volumes, health checks, ports, and some of the Coolify magic.
Caveats
TLS:
EdgeDB would ideally have its own certificates generated with files. These could be set via the following environment variables:
These are included in the PR's
edgedb.yaml
, but commented out as above.Currently each time the service is restarted, EdgeDB client starts warning:
Considerations
With External Database
EdgeDB can also be used with an external Postgres DB, which could be the way to go when in Coolify to leverage the backups etc.?