Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add edgedb configuration #2058

Merged

Conversation

jere-co
Copy link
Contributor

@jere-co jere-co commented Apr 23, 2024

EdgeDB has a launch week and it's reaching 5.0, so it feels like a good time to add it (back) to Coolify.

This PR includes EdgeDB logo and adds the edgedb.yaml, which includes setting environment the variables, volumes, health checks, ports, and some of the Coolify magic.

Caveats

TLS:

EdgeDB would ideally have its own certificates generated with files. These could be set via the following environment variables:

# - EDGEDB_SERVER_TLS_CERT_FILE= 
# - EDGEDB_SERVER_TLS_KEY_FILE=

These are included in the PR's edgedb.yaml, but commented out as above.

Currently each time the service is restarted, EdgeDB client starts warning:

Connecting to EdgeDB instance 'example-instance-name' at exampledomain.com:5656...
edgedb error: ClientConnectionFailedError: invalid peer certificate: BadSignature

Considerations

With External Database

EdgeDB can also be used with an external Postgres DB, which could be the way to go when in Coolify to leverage the backups etc.?

edgedb.svg includes EdgeDB logo and add edgedb.yaml the
configuration for edgedb and postgres services. Commit includes setting
environment variables, volumes, health checks, and ports.
@jere-co jere-co changed the title Feature add edgedb configuration feat: add edgedb configuration Apr 23, 2024
@Xhoni96
Copy link

Xhoni96 commented May 22, 2024

@andrasbacsai Any chance you could have a look at this?

@DeVoresyah
Copy link

any updates on this?

@peaklabs-dev peaklabs-dev added the ⚙️ Service Issues requesting or PRs adding/fixing service templates. label Aug 27, 2024
Copy link

gitguardian bot commented Sep 19, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@ethras
Copy link

ethras commented Oct 5, 2024

Would love this

@peaklabs-dev peaklabs-dev removed the ⚙️ Service Issues requesting or PRs adding/fixing service templates. label Oct 8, 2024
@peaklabs-dev
Copy link
Member

Thanks for the PR, this needs to be added to the codebase as a DB (I will leave this open for now).

@jere-co
Copy link
Contributor Author

jere-co commented Oct 9, 2024

@peaklabs-dev Sounds good! I've understood quite a bit more since April when this was made, so there's probably much to improve here.

Meanwhile I've been using Ports Mapping to bypass Traefik all-together, due to running into issues there. I would love to get this nailed down on Coolify, as it's truly not straightforward at the moment.

Some worthy discussions regarding EdgeDB and Traefik:

Additionally, EdgeDB runs on PostgreSQL, so Coolify's existing backups work, but if anyhow possible, EdgeDB's own dump would be just excellent to have.

@peaklabs-dev peaklabs-dev added the ⚙️ Database A label for PRs that add a new database. label Oct 10, 2024
@peaklabs-dev
Copy link
Member

Thanks for the PR. Databases should not be added as service templates, they need to be added differently to the codebase. You can search for keydb for example to see how other DBs have been added. Could you please update your PR with these changes? If you do not have time to do it this way, I will close the PR for now.

@peaklabs-dev peaklabs-dev marked this pull request as draft October 14, 2024 12:01
@peaklabs-dev peaklabs-dev added the 💤 Waiting for feedback Issues awaiting a response from the author. label Oct 14, 2024
@KaelWD
Copy link

KaelWD commented Oct 14, 2024

The way this is set up isn't really a new database, it's postgres with a frontend.

@peaklabs-dev peaklabs-dev changed the base branch from main to next October 14, 2024 12:50
@peaklabs-dev
Copy link
Member

Oh I see. I will add this then. Thank you for the PR. I will test it and fix it if necessary.

@peaklabs-dev peaklabs-dev marked this pull request as ready for review October 14, 2024 12:50
@peaklabs-dev peaklabs-dev merged commit e8865d1 into coollabsio:next Oct 14, 2024
1 check passed
@github-actions github-actions bot removed 💤 Waiting for feedback Issues awaiting a response from the author. ⚙️ Database A label for PRs that add a new database. labels Oct 14, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants