Allow for expected kube-bench failures with bottlerocket #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be fixed properly with aquasecurity/kube-bench#808 and bottlerocket-os/bottlerocket#1295 But, as these are known failures, this should not be a failure in our CI. Workaround by patching kube-bench config for bottlerocket config paths, and allowing for a known number of failures.
aidy
force-pushed
the
fix_kubebench_bottlerocket
branch
from
35719cc
to
a00446d
Compare
aidy
changed the title
ettiee
reviewed
Feb 10, 2021
| - "/etc/kubernetes/kubelet.conf" | ||
| - "/var/lib/kubelet/kubeconfig" | ||
| - "/etc/kubernetes/kubelet-kubeconfig" | ||
| - "/etc/kubernetes/kubelet/kubeconfig" |
There was a problem hiding this comment.
Patched addition from default config
There was a problem hiding this comment.
| - "/var/lib/kubelet/config.yaml" | ||
| - "/var/lib/kubelet/config.yml" | ||
| - "/etc/kubernetes/kubelet/kubelet-config.json" | ||
| - "/etc/kubernetes/kubelet/config" |
There was a problem hiding this comment.
Patched addition from default config
| - /var/snap/microk8s/current/args/kube-proxy | ||
| kubeconfig: | ||
| - "/etc/kubernetes/kubelet-kubeconfig" | ||
| - "/etc/kubernetes/kubelet/config" |
There was a problem hiding this comment.
Patched addition from default config
ettiee
approved these changes
Feb 10, 2021
dan-slinky-ckpd
approved these changes
Feb 10, 2021
This was referenced Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for expected kube-bench failures with bottlerocket
This should be fixed properly with aquasecurity/kube-bench#808 and bottlerocket-os/bottlerocket#1295
But, as these are known failures, this should not be a failure in our CI.
Workaround by patching kube-bench config for bottlerocket config paths, and allowing for a known number of failures.
connects #181
depends #178