Integrate PureeSQLiteStorage with androidx.sqlite #67
+30
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate PureeSQLiteStorage with AndroidX SQLite
This PR is just a proposal. If you can not accept, please feel free to close this.
Why
AndroidX provides SQLite support library. This library handles the framework's SQLite database well.
I think it is more reliable than using
SQLiteOpenHelperdirectly.Reference
I referenced implementation of AndroidX Room and JavaDoc of SupportSQLiteOpenHelper.
It calls
getWritableDatabaseevery query execution instead of keeping a reference of the database instance.Also, it has followed it in this implementation.