-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2] New interfaces to configure Puree #22
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rejasupotaro
changed the title
[WIP] Propose v2.0.0
[WIP] Propose new interfaces to configure Puree
Feb 20, 2015
rejasupotaro
changed the title
[WIP] Propose new interfaces to configure Puree
[WIP] [Proposal] New interfaces to configure Puree
Feb 20, 2015
@sys1yagi @slightair @gfx What do you think? |
LGTM. 👍 |
rejasupotaro
changed the title
[WIP] [Proposal] New interfaces to configure Puree
[Proposal] New interfaces to configure Puree
Feb 24, 2015
@sys1yagi @slightair @gfx Finished. We decided to focus on managing logs in this library. I'll upload to jcenter if there is anything. |
LGTM 👍 |
👀 |
Thanks guys! |
rejasupotaro
added a commit
that referenced
this pull request
Feb 26, 2015
[Proposal] New interfaces to configure Puree
gfx
changed the title
[Proposal] New interfaces to configure Puree
[v2] New interfaces to configure Puree
Jun 11, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to change interfaces to configure Puree. Because
TAG
when I send logBefore
Destination definition is far apart from sender.
I need to know where I should send logs.
In addition, It's not good that I have to specify output plugin by String.
After
It's easy to understand where log is sent at a glance.
It looks simple and intuitive.
Todo