Add correct github API header and update test

cookpad · Mar 28, 2022 · 4a71afc · 4a71afc
1 parent d42e326
commit 4a71afc
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 8 deletions.
diff --git a/README.md b/README.md
@@ -13,7 +13,7 @@ regardless of context.
 
 ```yml
 - name: Brakeman
-  uses: cookpad/[email protected].3
+  uses: cookpad/[email protected].4
   env:
     GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
 ```
@@ -28,7 +28,7 @@ regardless of context.
   run: |
     brakeman -f json > tmp/brakeman.json || exit 0
 - name: Brakeman
-  uses: cookpad/[email protected].3
+  uses: cookpad/[email protected].4
   env:
     GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
     REPORT_PATH: tmp/brakeman.json
@@ -38,7 +38,7 @@ regardless of context.
 
 ```yml
 - name: Brakeman
-  uses: cookpad/[email protected].3
+  uses: cookpad/[email protected].4
   env:
     GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
     PROJECT_PATH: my_rails_app
@@ -57,7 +57,7 @@ jobs:
     steps:
     - uses: actions/checkout@v1
     - name: Brakeman
-      uses: cookpad/[email protected].3
+      uses: cookpad/[email protected].4
       env:
         GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
 ```

diff --git a/lib/github_check_run_service.rb b/lib/github_check_run_service.rb
@@ -22,9 +22,7 @@ def run
 
     result = {}
     @annotations.each_slice(MAX_ANNOTATIONS_SIZE) do |annotation|
-      post_result = client_patch(id, annotation)
-      result.merge(post_result)
-      puts post_result
+      result.merge(client_patch(id, annotation))
     end
     result
   end

diff --git a/lib/github_client.rb b/lib/github_client.rb
@@ -24,7 +24,8 @@ def headers
     @headers ||= {
       "Content-Type": 'application/json',
       "Authorization": "token #{@github_token}",
-      "User-Agent": @user_agent
+      "User-Agent": @user_agent,
+      "Accept": 'application/vnd.github.v3+json'
     }
   end