Change Raven filter's secure_headers config to be case insensitive #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cookpad/dev-infra |
|
No spec? |
|
Specs coming up 👍 |
|
See 2e8c3dd |
|
domo arigato 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows HTTP header names passed to RavenParameterFilterProcessor#create to be capitalized.
When RavenParameterFilterProcessor checks if a HTTP header is included in
@header_filters, it downcases ONLY the request's header:blouson/lib/blouson/raven_parameter_filter_processor.rb
Line 60 in b9add28
This means that if the user capitalizes a header name in
secure_headers, it just slips through the filter, and the content goes out to Sentry. This is pretty much confusing.Wouldn't it be nicer to just downcase
header_filtersat the library side?