feat: Reducing time taken when wait_workflow used #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [modified] Avoidable loss of 10sec of runner * [modified] Ash script issues * https://github.com/koalaman/shellcheck/wiki/SC2113 * https://github.com/koalaman/shellcheck/wiki/SC2086 * https://fr.wikipedia.org/wiki/Shebang * https://dev.to/meleu/what-the-shebang-really-does-and-why-it-s-so-important-in-your-shell-scripts-2755 * [modified] README.md - applying markdown best practice
Contributor
Author
|
Up @keithconvictional :) |
Contributor
keithconvictional
left a comment
keithconvictional
left a comment
There was a problem hiding this comment.
@Steph0 Thanks for putting this together. Changes look good. Give me 24 hours to test them out.
Contributor
Author
|
@keithconvictional my pleasure! :) |
Contributor
Author
Contributor
|
@Steph0 released in v1.4.0. Thanks for contributing! |
Contributor
Author
|
@keithconvictional thanks to you! Migrating all our apps to 1.4.0 as of today :) |
|
I've tested between v1.3 and v1.4 and v1.3 is more stable because of that first 10 second sleep than v1.4, but I like the feature of v1.5 xD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sleep in
trigger_workflowis a loss of 10 seconds on Github runners (which cost money) that can be avoided sincewait_for_workflow_to_finishwill still do the job if user wants to wait for workflow.Especially if a user uses
wait_workflow=falsesince he specifically asks to not wait.Concerned lines:
[modified] Ash script issues
[modified] README.md - applying markdown best practices