Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a regional analysis triggers a request to start spot instance workers, if the request would lead the total number of workers to exceed our configured limit (~6x higher on prod vs. staging), the request is totally ignored.
This PR changes that behavior and reduces the likelihood requests will be ignored:
Three additional refinements could be considered -- per-access group limits, further reducing the number of instances requested when analyses don't have frequency-based routes (we don't yet expose
hasFrequency()
in a convenient place though), and sizing the spot instance request based on observed tasks per minute.