Increase limit on geographic extents for grids, OSM, and GTFS #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From 250k sq km to 975k sq km. Addresses #815.
trevorgerhardt
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a longstanding 250k sq km limit on grids, and in #748 applied the same limit to GTFS and OSM. This limit is too strict; a few users have encountered the size error when building a network with previously uploaded OSM and the latest worker version.
I considered separate limits for grids (because the 250k limit was in place for a while) and network inputs, but I don't think the added conditionals are worth it.
We should test uploading a large (e.g. California-size) shapefile and converting it to a grid to ensure this works. I am less concerned about the network input files, because we did not have a limit on those until recently.