-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: simplified commitlint script #151
Conversation
@commitlint/travis-cli/cli.js
Outdated
main().catch(err => { | ||
console.log({err}); | ||
setTimeout(() => { | ||
console.log({err}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this - why log the error twice? why not use console.error(err); process.exit(1);
instead?
@commitlint/travis-cli/cli.js
Outdated
}); | ||
|
||
function main() { | ||
return new Promise((resolve, reject) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
execa
returns a Promise so you shouldn't need to use the Promise constructor
@commitlint/travis-cli/package.json
Outdated
}, | ||
"scripts": { | ||
"deps": "dep-check", | ||
"lint": "npx xo", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why npx
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The over-simplified answer is: I introduced npx
at one point to ensure the dev setup works regardless of the current state it is in. I'll keep them in travis-cli
for now to be consistent, will remove them from all packages in one go in the near future.
Thanks for the review @felixfbecker! |
@commitlint/travis-cli
@commitlint/travis-cli
ToDo
git stash
beforegit checkout
git stash
afterwardsDescription
--from $TRAVIS_BRACH --to $TRAVIS_COMMIT
Motivation and Context
*
@commitlint/travis-cli
is designed to be zero-config on TravisCIUsage examples
How Has This Been Tested?
Types of changes
Checklist: