-
Notifications
You must be signed in to change notification settings - Fork 100
fix(lib): getting .git from parent dir #74
fix(lib): getting .git from parent dir #74
Conversation
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 123 126 +3
=====================================
+ Hits 123 126 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
.all-contributorsrc
Outdated
"avatar_url": "https://avatars3.githubusercontent.com/u/750319?v=3", | ||
"profile": "https://github.com/standy", | ||
"contributions": [ | ||
"bug", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use code
instead of bug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix! I see you added a new package, but yarn.lock
hasn't been committed? Can you update it? Or am I missing something?
I wonder why library has lockfile, isnt it ignored by package users? Looks like just yet another file to maintain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah cool! Didn't notice that! But it is not ignored for development? Every contributor should have the same packages, right?
Having same packages for every contributor does not guarantee that package will work for users, I think that having some diversity would be better for contributors |
Closes #72