Skip to content
This repository has been archived by the owner on Feb 5, 2018. It is now read-only.

feat(validateMessage): Allow semver commits #17

Conversation

jcollado
Copy link
Contributor

In this PR the IGNORED regular expression is updated to skip commits that contain just a valid semver as the ones generated by npm version.

Closes #13

@codecov-io
Copy link

Current coverage is 96.36%

Merging #17 into master will increase coverage by +0.07% as of 5804653

@@            master     #17   diff @@
======================================
  Files            1       1       
  Stmts           54      55     +1
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit             52      53     +1
  Partial          0       0       
  Missed           2       2       

Review entire Coverage Diff as of 5804653

Powered by Codecov. Updated on successful CI builds.

@jcollado jcollado changed the title Allow semver commits feat(validateMessage): Allow semver commits Feb 2, 2016
@kentcdodds
Copy link
Collaborator

I need to give you an apology. For some reason, I want watching this repository so I want getting notifications about issues and pull requests. I am so incredibly sorry. Please forgive me. I really feel awful. I hope my unresponsiveness doesn't hinder you contributing more in the future.

As for your specific pull request, I'll give it a closer look soon.

@kentcdodds
Copy link
Collaborator

This is great. Thanks for the work. Unfortunately it no longer merges cleanly (sorry about that!) If you could please rebase and update the PR to the current codebase, I'd really appreciate it. Thank you.

@jcollado jcollado force-pushed the allow-semver-commits branch from a6ebea2 to a7a403e Compare February 2, 2016 17:38
@jcollado
Copy link
Contributor Author

jcollado commented Feb 2, 2016

@kentcdodds Rebased

@kentcdodds
Copy link
Collaborator

Excellent. Thanks!

kentcdodds pushed a commit that referenced this pull request Feb 2, 2016
feat(validateMessage): Allow semver commits
@kentcdodds kentcdodds merged commit cd5aaca into conventional-changelog-archived-repos:master Feb 2, 2016
@jcollado jcollado deleted the allow-semver-commits branch February 2, 2016 17:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants