Merge pull request #24 from remy/master

Support empty commits
conventional-changelog-archived-repos · Mar 6, 2016 · bb0afb6 · bb0afb6
2 parents 0d571c5 + 4de3a58
commit bb0afb6
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -33,7 +33,16 @@ var error = function() {
 };
 
 
-var validateMessage = function(message) {
+var validateMessage = function(raw) {
+  var message = (raw || '').split('\n').filter(function (str) {
+    return str.indexOf('#') !== 0;
+  }).join('\n');
+
+  if (message === '') {
+    console.log('Aborting commit due to empty commit message.');
+    return false;
+  }
+
   var isValid = true;
 
   if (IGNORED.test(message)) {

diff --git a/index.test.js b/index.test.js
@@ -142,6 +142,11 @@ describe('validate-commit-msg.js', function() {
       expect(logs).to.not.deep.equal([]);
     });
 
+    it('should allow for empty commits', function() {
+      expect(m.validateMessage('# this is just a comment')).to.equal(INVALID);
+      expect(logs).to.deep.equal(['Aborting commit due to empty commit message.']);
+    });
+
 
     it('should handle undefined message"', function() {
       expect(m.validateMessage()).to.equal(INVALID);