fix(scope): Allow no scope in the commit message when validate is set…

… to true. (#69)
conventional-changelog-archived-repos · Mar 8, 2017 · 7a580ce · 7a580ce
1 parent b737246
commit 7a580ce
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/lib/validateMessage.js b/lib/validateMessage.js
@@ -153,6 +153,11 @@ function validateScope(isValid, scope) {
       error('a scope is required !');
       isValid = false;
     }
+    // If scope is not provided, we ignore the rest of the testing and do early
+    // return here.
+    if (scopes.length === 0) {
+      return isValid;
+    }
     if (isValid && multipleScopesAllowed) {
       scopes.forEach(validateIndividualScope);
     }

diff --git a/test/validateMessage.test.js b/test/validateMessage.test.js
@@ -232,6 +232,19 @@ describe('validate-commit-msg.js', function() {
       m.config.scope = undefined;
     });
 
+    it('should allow no scope when only validate is set to true', function() {
+      var msg = 'chore: Publish';
+
+      m.config.scope = {
+        validate: true
+      };
+
+      expect(m.validateMessage(msg)).to.equal(VALID);
+      expect(logs).to.deep.equal([]);
+
+      m.config.scope = undefined;
+    });
+
     it('should allow empty scope', function() {
       expect(m.validateMessage('fix: blablabla')).to.equal(VALID);
       expect(errors).to.deep.equal([]);