Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect handling of relative links in readme #104

Closed
dakujem opened this issue Jan 12, 2018 · 4 comments · Fixed by #105
Closed

Incorrect handling of relative links in readme #104

dakujem opened this issue Jan 12, 2018 · 4 comments · Fixed by #105
Labels
Milestone

Comments

@dakujem
Copy link
Contributor

dakujem commented Jan 12, 2018

Relative links within readme markdown files are not being handled well.

Problem

  • all the relative links pointing to other files within the repository are generated with a redundant space " " character preceding the relative link part
  • as a result, users clicking the links get 404 error on github

Example

What Value
realtive link in markdwon source examples/ajax/ExamplePresenter.php
current incorrectly generated absolute link https://github.com/dakujem/selectoo/blob/master /examples/ajax/ExamplePresenter.php
desired correct absolute link https://github.com/dakujem/selectoo/blob/master/examples/ajax/ExamplePresenter.php

Note the space character in the blob/master /examples part of the generated URL

Link to where this issue can be observed:
https://componette.com/dakujem/selectoo/

@f3l1x f3l1x added the bug label Jan 12, 2018
@f3l1x f3l1x added this to the v1.3.0 milestone Jan 12, 2018
@f3l1x
Copy link
Member

f3l1x commented Jan 12, 2018

Thanks. Do mind to resolve this bug?

@dakujem dakujem mentioned this issue Jan 12, 2018
@dakujem
Copy link
Contributor Author

dakujem commented Jan 12, 2018

So I found the bug and fixed it using the web interface. Haven't tested it, but it is obviously a typo-bug.

f3l1x pushed a commit that referenced this issue Jan 17, 2018
…oses #105]

The fix removes redundant space character inside `getBlobUrl`-generated URLs, fixes #104
@f3l1x
Copy link
Member

f3l1x commented Jan 17, 2018

Thank you.

@dakujem
Copy link
Contributor Author

dakujem commented Jan 17, 2018

No problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants