This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Lukebailey/infra 387 explore and create a micro interaction #54
Open
lukerohanbailey
wants to merge
24
commits into
main
Choose a base branch
from
lukebailey/infra-387-explore-and-create-a-micro-interaction
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Lukebailey/infra 387 explore and create a micro interaction #54
lukerohanbailey
wants to merge
24
commits into
main
from
lukebailey/infra-387-explore-and-create-a-micro-interaction
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion' into lukebailey/infra-386-create-a-a11y-checkbox
…rops and ToggleProps
…ailey/infra-387-explore-and-create-a-micro-interaction
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The task here was to explore and create a micro-interaction for the checkbox component in the ui-kit. Primarily the PR is a lofi suggestion for how we could setup micro-interactions for components. There are decisions and discussion to be had around:
animateIcons
directory placement and general approach of segregating animation and static iconsreact-spring
orframer-motion
References