Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CMakePresets to conveniently build and work with the sources #92

Merged
merged 2 commits into from
Feb 24, 2024
Merged

Add CMakePresets to conveniently build and work with the sources #92

merged 2 commits into from
Feb 24, 2024

Conversation

christianparpart
Copy link
Member

@christianparpart christianparpart commented Feb 24, 2024 •
edited
Loading

  • Add CMakePresets to conveniently build and work with the sources
  • Add vcpkg.json and make use of it
  • Fix formatting in scan.cpp
  • Partially use system package for google-benchmark where I know it is available (Fedora, vcpkg)
  • Some more cleanups around CI pipeline ;-(

@christianparpart christianparpart force-pushed the improvement/cmake-presets branch 7 times, most recently from 5fc7202 to 94ea23b Compare February 24, 2024 17:59
Yaraslaut
Yaraslaut reviewed Feb 24, 2024
View reviewed changes
Copy link
Member

@Yaraslaut Yaraslaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback

cmake/presets/common.json Outdated Show resolved Hide resolved
@christianparpart christianparpart force-pushed the improvement/cmake-presets branch 4 times, most recently from 958c3ae to 6716ff1 Compare February 24, 2024 20:14
@christianparpart
Fix formatting in scan.cpp
7d25a2d 
Signed-off-by: Christian Parpart <[email protected]>
@christianparpart christianparpart force-pushed the improvement/cmake-presets branch 5 times, most recently from 7cc928b to 190310b Compare February 24, 2024 20:50
@christianparpart
Add/improve CMakePresets to conveniently build and work with the sour…
0ee9785 
…ces & bump checkout action

Signed-off-by: Christian Parpart <[email protected]>
@christianparpart christianparpart force-pushed the improvement/cmake-presets branch from 190310b to 0ee9785 Compare February 24, 2024 20:55
Yaraslaut
Yaraslaut approved these changes Feb 24, 2024
View reviewed changes
Copy link
Member

@Yaraslaut Yaraslaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating actions, finally they are green :)

@Yaraslaut Yaraslaut merged commit d5ae8ec into master Feb 24, 2024
15 checks passed
@Yaraslaut Yaraslaut deleted the improvement/cmake-presets branch February 24, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yaraslaut Yaraslaut Yaraslaut approved these changes

Assignees
No one assigned
Labels
CI CMake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christianparpart @Yaraslaut