Problem: Catch2 is always required #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that if one doesn't need to test libunicode (for example, using it as a dependency), they still need Catch2. Solution: make this requirement depend on LIBUNICODE_TESTING flag
Yaraslaut
force-pushed
the
catch2-no-testing
branch
from
540af78 to
bf00956
Compare
|
Thanks a lot, I rebased branch and enabled auto merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that if one doesn't need to test libunicode (for example, using it as a dependency), they still need Catch2.
Solution: make this requirement depend on LIBUNICODE_TESTING flag