Improvement/better simd config #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Parpart <[email protected]>
…ntrinsics) Signed-off-by: Christian Parpart <[email protected]>
|
@Yaraslaut the changes done so far are IMHO needed. But it still breaks Fedora on test cases. I noticed that we build against installed UCD directory. We also break accessing them during test. 🤔 |
|
NB: Fedora (latest) seems to use Unicode 16.0.0 already, we need to adapt/fix our scripts accordingly (in another PR) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before it was not really clear what SIMD implementation is being compiled with.
Now, the package maintainer can explicitly decide what SIMD implementation is used, which is one of:
std::simdCompiler intrinsics is the default here, because that's what is already field tested and known to work well.
noneis a good fallback for systems (RISC-V?) that we did not handle yet or do not have SIMD, andstd::simdis the future SIMD C++ API, which seems not to be that reliable yet.