Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SIMD scanning on macOS (using std::simd) #102

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Fix SIMD scanning on macOS (using std::simd) #102

merged 3 commits into from
Sep 17, 2024

Conversation

christianparpart
Copy link
Member

No description provided.

@Yaraslaut
Copy link
Member

I think that we need to add github action for macos, so we do not break something in the future

@github-actions github-actions bot added the CI label Sep 17, 2024
Yaraslaut
Yaraslaut approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@Yaraslaut Yaraslaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use this way, and when simd is in the standard then most likely such issues will not appear

@Yaraslaut Yaraslaut merged commit 28aacf5 into master Sep 17, 2024
9 checks passed
@Yaraslaut Yaraslaut deleted the fix/macOS-build branch September 17, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yaraslaut Yaraslaut Yaraslaut approved these changes

Assignees
No one assigned
Labels
CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christianparpart @Yaraslaut