Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: timeout semantic-release step after 1 hour #7

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

dsanders11
Copy link
Member

The GH token acquired and passed to the semantic-release step is only good for 1 hour, and if a maintainer provides a CFA token after that time we end up with the npm publish going through but none of the follow-up steps on GitHub (creating the release, commenting on PRs, etc). So let's timeout this step after 1 hour to prevent this edge case.

@dsanders11 dsanders11 requested review from a team as code owners November 13, 2024 20:31
@dsanders11 dsanders11 merged commit 732eeb2 into main Nov 13, 2024
@dsanders11 dsanders11 deleted the fix/timeout-semantic-release branch November 13, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants