perf(cli): long start due to synchronous config init in normal flow run

[uinstinct]

Description

When doing runNormalFlow, we need the config only for rules injection.

We already fetch the config again when initializing services for config.

resolves CON-4174

AI Code Review

• Team members only: AI review runs automatically when PR is opened or marked ready for review
• Team members can also trigger a review by commenting @continue-review

Checklist

• [] I've read the contributing guide
• [] The relevant docs, if any, have been updated or created
• [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

reduction of init time by approx 2 seconds

before

after

Tests

[ What tests were added or updated to ensure the changes work as expected? ]

---

Summary by cubic

Make CLI start faster by initializing normal-flow config asynchronously instead of blocking; startup time drops by ~2 seconds. Addresses CON-4174.

• Refactors
  • Initialize normal flow and config in parallel; inject rules after config is ready.
  • Remove wasOnboarded return from initializeServices; onboarding stays internal.

[cubic-dev-ai]

1 issue found across 2 files

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name="extensions/cli/src/onboarding.ts">

<violation number="1" location="extensions/cli/src/onboarding.ts:300">
Discarding the promise from runNormalFlow here lets onboarding continue even if config initialization fails, and the resulting rejection becomes unhandled.</violation>
</file>

_{React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.}

[cubic-dev-ai]

Discarding the promise from runNormalFlow here lets onboarding continue even if config initialization fails, and the resulting rejection becomes unhandled.

Prompt for AI agents

Address the following comment on extensions/cli/src/onboarding.ts at line 300:

<comment>Discarding the promise from runNormalFlow here lets onboarding continue even if config initialization fails, and the resulting rejection becomes unhandled.</comment>

<file context>
@@ -280,24 +280,35 @@ export async function initializeWithOnboarding(
-  if (rules &amp;&amp; rules.length &gt; 0 &amp;&amp; !result.wasOnboarded) {
-    result.config = await injectRulesIntoConfig(result.config, rules);
+    // when running normal flow, initialize (remote) config asynchronously
+    void (async () =&gt; {
+      const onboardingResult = await runNormalFlow(
+        authConfig,
</file context>

✅ Addressed in 452da6e

[RomneyDa]

@uinstinct cubic comment seems right

Do we actually need the rules injected in config for onboarding? Could we just not load config/only load model or similar?

[uinstinct]

@uinstinct cubic comment seems right

Do we actually need the rules injected in config for onboarding? Could we just not load config/only load model or similar?

Right.
I dove a little deeper and rules injection is unnecessary because we are injecting the rules in the SystemMessageService. Also running the normalFlow is unnecessary because all parts of it are done in ConfigService, MCPService and AuthService in service initialization.

[sestinj]

🎉 This PR is included in version 1.24.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀