Skip to content

Conversation

RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Sep 10, 2025

Description

In ts/tsx files, tell models not to use any


Summary by cubic

Add a rule to ban the any type in .ts/.tsx files to improve type safety. Prefer unknown or correct types, with any allowed only for explicit typecasting in test mocks (addresses Linear CON-3885).

@RomneyDa RomneyDa marked this pull request as ready for review September 10, 2025 22:14
@RomneyDa RomneyDa requested a review from a team as a code owner September 10, 2025 22:14
@RomneyDa RomneyDa requested review from sestinj and removed request for a team September 10, 2025 22:14
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 10, 2025
Copy link

AI Code Review

AI review failed due to service initialization issues. Please check the Continue API key and configuration.

No specific line comments generated.


💡 To request a new detailed review, comment @continue-detailed-review

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Copy link
Collaborator

@tingwai tingwai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very much needed

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Sep 11, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 11, 2025
@RomneyDa RomneyDa merged commit 4a9ea24 into main Sep 11, 2025
56 checks passed
@RomneyDa RomneyDa deleted the dallin/con-3885-no-any-rule branch September 11, 2025 22:13
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Sep 11, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2025
@github-actions github-actions bot added the tier 2 Important feature that adds new capabilities to the platform or improves critical user journeys label Sep 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. tier 2 Important feature that adds new capabilities to the platform or improves critical user journeys
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants