This repository has been archived by the owner on Nov 11, 2023. It is now read-only.
Fix React import on generated d.ts #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React should be imported with * because of React.ReactNode is not being exported with React Object I'm using TSX
|
First of all, good catch, But it's really strange, we are using this project in many of our products and never had this error before and |
fabien0102
approved these changes
Nov 20, 2018
|
WOW @diegochavez, great work! Thanks for this amazing PR! 🔥 |
TejasQ
approved these changes
Nov 20, 2018
|
Published to Restful React v6.1.1! |
|
Awesome thanks, great library guys! 👍 |
|
💞 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React should be imported with * because of React.ReactNode is not being exported with React Object I'm using TSX
Why
After installing the package it throws an error React
has no default export