Skip to content
This repository has been archived by the owner on Nov 11, 2023. It is now read-only.

Remove engine in package.json #55

Merged
merged 1 commit into from
Sep 21, 2018
Merged

Conversation

chilijung
Copy link
Contributor

Why

I don't think the engine setting is right in package.json

It cause built fail in now

> warning @canner/[email protected]: The engine "vscode" appears to be invalid.
> info [email protected]: The platform "linux" is incompatible with this module.
> info "[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
> warning [email protected]: The engine "vscode" appears to be invalid.
> [4/5] Linking dependencies..

FYI: https://docs.npmjs.com/files/package.json#engines

@fabien0102
Copy link
Contributor

Logically it's just a warning, but I'm agree that this vscode as engine is weird 😄

@fabien0102 fabien0102 requested a review from TejasQ September 21, 2018 10:48
@chilijung
Copy link
Contributor Author

In now it will break the build process.

@fabien0102 fabien0102 merged commit 2491b0c into contiamo:master Sep 21, 2018
@TejasQ
Copy link
Contributor

TejasQ commented Sep 21, 2018

Thank you, @chilijung!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants