This repository has been archived by the owner on Nov 11, 2023. It is now read-only.
4.0.1 #27
Merged
4.0.1 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
peterszerzo
reviewed
Aug 14, 2018
| @@ -201,7 +201,7 @@ class ContextlessPoll<TData, TError> extends React.Component< | |||
| ...requestOptions, | |||
|
|
|||
| headers: { | |||
| Prefer: `wait=${wait};${lastPollIndex ? `index=${lastPollIndex}` : ""}`, | |||
| Prefer: `wait=${wait}s;${lastPollIndex ? `index=${lastPollIndex}` : ""}`, | |||
There was a problem hiding this comment.
Is the wait key inside the header among people using this library? If not, waitFor sounds more readable.
There was a problem hiding this comment.
It's actually the Contiamo spec.
More info: internal link, non-Contiamo people look away.
There was a problem hiding this comment.
Makes sense - for such a small naming difference we can leave it as it is.
fabien0102
approved these changes
Aug 14, 2018
peterszerzo
approved these changes
Aug 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Need correct polling spec.