This repository has been archived by the owner on Nov 11, 2023. It is now read-only.
Refactor URL handling to account for query params #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabien0102
suggested changes
Jul 18, 2018
src/Get.tsx
Outdated
| public static getDerivedStateFromProps(props: Pick<GetComponentProps, "lazy">) { | ||
| return { loading: !props.lazy }; | ||
| } | ||
|
|
||
| public static defaultProps = { |
There was a problem hiding this comment.
You should type your defaultProps here
src/Get.tsx
Outdated
| @@ -159,9 +161,11 @@ class ContextlessGet<T> extends React.Component<GetComponentProps<T>, Readonly<G | |||
| }; | |||
|
|
|||
| public fetch = async (requestPath?: string, thisRequestOptions?: RequestInit) => { | |||
| const { base, path, resolve } = this.props; | |||
| const { base, path, resolve } = this.props as PropsWithDefaults<T>; | |||
There was a problem hiding this comment.
So bad… we can fix this together ;)
There was a problem hiding this comment.
Come on then, show me how it's done.
There was a problem hiding this comment.
fabien0102
approved these changes
Jul 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Currently, when requesting
/collection/resource?filter=blah, nestedGet,MutateandPollcomponents naïvely append things past the query string. This leads to incorrect behavior.This PR makes URL handling more reliable by treating query strings as they should be treated.
Side effects
This PR also makes the following optimizations/adjustments to the codebase:
defaultProps.getDerivedStateFromPropsbecause we only want initial state from props sinceGets are not fully controlled.