chore: tiny cleanups

contentful · May 24, 2023 · 5f21671 · 5f21671
1 parent b793f5b
commit 5f21671
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 13 deletions.
diff --git a/src/__tests__/resolveReference.spec.ts b/src/__tests__/resolveReference.spec.ts
@@ -57,7 +57,7 @@ describe('resolveReference', () => {
     });
 
     it('resolves it from the editor', async () => {
-      const prom = resolveReference({
+      const promise = resolveReference({
         entityReferenceMap: new Map(),
         referenceId: '1',
         isAsset: true,
@@ -79,13 +79,13 @@ describe('resolveReference', () => {
         },
       } as MessageEvent);
 
-      const result = await prom;
+      const result = await promise;
 
       expect(result).toEqual(expected);
     });
 
     it('ignores different entries while waiting for the reference', async () => {
-      const prom = resolveReference({
+      const promise = resolveReference({
         entityReferenceMap: new Map(),
         referenceId: '1',
         isAsset: true,
@@ -123,19 +123,19 @@ describe('resolveReference', () => {
         },
       } as MessageEvent);
 
-      const result = await prom;
+      const result = await promise;
 
       expect(result).toEqual(expected);
     });
 
     it('dedupes requests', async () => {
-      const prom = resolveReference({
+      const promise = resolveReference({
         entityReferenceMap: new Map(),
         referenceId: '1',
         isAsset: true,
       });
 
-      const prom2 = resolveReference({
+      const promise2 = resolveReference({
         entityReferenceMap: new Map(),
         referenceId: '1',
         isAsset: true,
@@ -149,8 +149,8 @@ describe('resolveReference', () => {
         },
       } as MessageEvent);
 
-      const result = await prom;
-      const result2 = await prom2;
+      const result = await promise;
+      const result2 = await promise2;
 
       expect(result).toEqual(expected);
       expect(result2).toEqual(expected);
@@ -198,7 +198,7 @@ describe('resolveReference', () => {
     });
 
     it('resolves it from the editor', async () => {
-      const prom = resolveReference({
+      const promise = resolveReference({
         entityReferenceMap: new Map(),
         referenceId: '1',
       });
@@ -219,7 +219,7 @@ describe('resolveReference', () => {
         },
       } as MessageEvent);
 
-      const result = await prom;
+      const result = await promise;
 
       expect(result).toEqual(expected);
     });

diff --git a/src/helpers/resolveReference.ts b/src/helpers/resolveReference.ts
@@ -65,7 +65,6 @@ function loadReference(referenceId: string, isAsset?: boolean): ReferencePromise
 export async function resolveReference(info: {
   entityReferenceMap: EntityReferenceMap;
   referenceId: string;
-  isAsset?: false;
 }): Promise<{ reference: EntryProps; typeName: string }>;
 export async function resolveReference(info: {
   entityReferenceMap: EntityReferenceMap;

diff --git a/src/rest/entities.ts b/src/rest/entities.ts
@@ -30,8 +30,7 @@ async function updateRef(
   const { reference } = await resolveReference({
     entityReferenceMap,
     referenceId: updateFromEntryEditor.sys.id,
-    // @ts-expect-error -- true or false is not equal to boolean
-    isAsset: isAsset(updateFromEntryEditor as EntryProps),
+    ...(isAsset(updateFromEntryEditor as EntryProps) ? { isAsset: true } : undefined),
   });
 
   if (!reference) {