refactor(form-controls): use functional components and react hooks #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshaaban0
requested review from
burakukula,
denkristoffer,
gui-santos and
m10l
as code owners
mshaaban0
commented
Nov 13, 2020
packages/forma-36-react-components/src/components/TextField/TextField.tsx
Show resolved
Hide resolved
|
Deploy preview for forma-36-react-components ready! Built with commit a41cdca https://deploy-preview-641--forma-36-react-components.netlify.app |
gui-santos
approved these changes
Nov 16, 2020
denkristoffer
requested changes
Nov 16, 2020
packages/forma-36-react-components/src/components/Textarea/Textarea.tsx
Outdated
Show resolved
Hide resolved
mshaaban0
commented
Nov 18, 2020
packages/forma-36-react-components/src/components/ControlledInput/ControlledInput.tsx
Show resolved
Hide resolved
54 tasks
packages/forma-36-react-components/src/components/ControlledInput/ControlledInput.tsx
Outdated
Show resolved
Hide resolved
packages/forma-36-react-components/src/components/ControlledInputField/ControlledInputField.tsx
Outdated
Show resolved
Hide resolved
packages/forma-36-react-components/src/components/Form/Form.tsx
Outdated
Show resolved
Hide resolved
packages/forma-36-react-components/src/components/Form/Form.tsx
Outdated
Show resolved
Hide resolved
packages/forma-36-react-components/src/components/Select/Select.tsx
Outdated
Show resolved
Hide resolved
packages/forma-36-react-components/src/components/Select/Select.tsx
Outdated
Show resolved
Hide resolved
packages/forma-36-react-components/src/components/SelectField/SelectField.tsx
Show resolved
Hide resolved
packages/forma-36-react-components/src/components/SelectField/SelectField.tsx
Outdated
Show resolved
Hide resolved
packages/forma-36-react-components/src/components/TextField/TextField.tsx
Outdated
Show resolved
Hide resolved
mshaaban0
force-pushed
the
refactor/form-controls-PUL-1251
branch
from
783e2c0 to
c264b46
Compare
|
@denkristoffer Thanks for all the useful comments, addressed 👍 |
packages/forma-36-react-components/src/components/ControlledInput/ControlledInput.tsx
Outdated
Show resolved
Hide resolved
denkristoffer
approved these changes
Nov 20, 2020
|
Great! |
mshaaban0
force-pushed
the
refactor/form-controls-PUL-1251
branch
2 times, most recently
from
22b81a1 to
60c2800
Compare
mshaaban0
force-pushed
the
refactor/form-controls-PUL-1251
branch
from
60c2800 to
8d49f55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR
Refactor form controls to use functional components and react hooks, why:
UNSAFElifecycle methodsNote: This shouldn't introduce any breaking changes, so if you see anything please flag it.
PR Checklist
readme.mdfile(s)