Allow setting a custom adapter #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
==========================================
- Coverage 69.58% 69.51% -0.08%
==========================================
Files 6 6
Lines 924 925 +1
Branches 163 163
==========================================
Hits 643 643
- Misses 281 282 +1
Continue to review full report at Codecov.
|
Khaledgarbaya
suggested changes
Jan 7, 2019
|
Alright @Khaledgarbaya I added a test that should verify the new config option |
phoebeschmidt
approved these changes
Jan 8, 2019
Khaledgarbaya
approved these changes
Jan 8, 2019
|
@Khaledgarbaya Is this ready to merge then? WOuld be nice to get the functionality in soon |
|
@Isigiel I am merging this now, do you want to update the contentful.js PR after this library is released |
|
🎉 This PR is included in version 6.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will need a corresponding update on the contentful.js library but lays the groundwork for setting a custom adapter.
Such as patrickhousley/ngx-axios-adapter to allow the usa of the contenful sdk in an angular universal situation