Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ratelimit #65

Merged
merged 1 commit into from
Nov 22, 2018
Merged

Fix ratelimit #65

merged 1 commit into from
Nov 22, 2018

Conversation

Khaledgarbaya
Copy link
Contributor

With the new Axios beta the defaults config are no longer carried to the instance.
This behaviour is breaking the ratelimit logic

@codecov
Copy link

codecov bot commented Oct 15, 2018

Codecov Report

Merging #65 into master will increase coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
+ Coverage   69.48%   69.65%   +0.16%     
==========================================
  Files           6        6              
  Lines         921      926       +5     
  Branches      163      164       +1     
==========================================
+ Hits          640      645       +5     
  Misses        281      281
Impacted Files Coverage Δ
lib/rate-limit.js 76.11% <100%> (+0.6%) ⬆️
lib/create-http-client.js 71.75% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f30a5b5...260796a. Read the comment docs.

@Khaledgarbaya
Copy link
Contributor Author

FYI, I made a PR to axios to allow for a custom config so so might not need this PR.

Copy link
Contributor

@phoebeschmidt phoebeschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be merged into @next instead of master? since it's relying on axios beta?

otherwise 👍

@Khaledgarbaya Khaledgarbaya changed the base branch from master to next November 2, 2018 08:49
@phoebeschmidt phoebeschmidt merged commit b768ae8 into next Nov 22, 2018
@phoebeschmidt phoebeschmidt deleted the fix/axios-config branch November 22, 2018 14:12
Khaledgarbaya added a commit that referenced this pull request Jan 31, 2019
With the new Axios beta the defaults config are no longer carried to the instance.
This behaviour is breaking the ratelimit logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants