Skip to content

Conversation

@jjolton-contentful
Copy link
Contributor

@jjolton-contentful jjolton-contentful commented Sep 26, 2025

Summary

  • Move status, result, and error fields under sys for AppActionCall
  • Update polling logic and tests to check sys.status instead of top-level fields
  • Extend raw response props to include createdBy

Description

  • Refactored AppActionCall entity to align with Contentful conventions: fields that are system-controlled live inside sys
  • Updated pollStructuredAppActionCall to resolve based on sys.status values (succeeded, failed, processing)
  • Adjusted unit tests accordingly to mock sys.status, sys.result, and sys.error
  • Cleaned up redundant top-level fields

Motivation and Context

  • Ensures consistency with how other system-managed fields are represented in Contentful entities
  • Reduces risk of user confusion by preventing direct mutation of system-controlled properties
  • Brings App Action Call entity and polling behavior in line with long-term design direction

Checklist (check all before merging)

  • Both unit and integration tests are passing
  • There are no breaking changes
  • Changes are reflected in the documentation

@jjolton-contentful jjolton-contentful force-pushed the fix/move-app-action-call-properties-to-sys branch from 6b2c69c to 698f946 Compare September 26, 2025 16:01
@jjolton-contentful jjolton-contentful marked this pull request as ready for review September 26, 2025 16:18
@jjolton-contentful jjolton-contentful requested a review from a team as a code owner September 26, 2025 16:18
@jjolton-contentful jjolton-contentful requested a review from a team September 26, 2025 16:30
@michaelpineirocontentful michaelpineirocontentful merged commit 5ee913b into master Sep 29, 2025
7 checks passed
@michaelpineirocontentful michaelpineirocontentful deleted the fix/move-app-action-call-properties-to-sys branch September 29, 2025 14:58
@contentful-automation
Copy link
Contributor

🎉 This PR is included in version 11.60.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@contentful-automation
Copy link
Contributor

🎉 This PR is included in version 12.0.0-beta.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants