Skip to content

Beta: migrate to new Rollup setup #2717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 5, 2025
Merged

Beta: migrate to new Rollup setup #2717

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
47af571
build: move to node v20
axe312ger Aug 20, 2025
0980f17
build: build typescript with rollup
axe312ger Aug 20, 2025
8314150
refactor: drastically reduce circular dependencies by eliminating ind…
axe312ger Sep 3, 2025
da923ae
build: replace rollup-dts which breaks with memory leak with plain ty…
axe312ger Sep 3, 2025
494074c
test: fix ignore paths for eslint and remove obsolete linting rule ex…
axe312ger Sep 3, 2025
a770575
ci: upgrade circleci images to latest
axe312ger Sep 3, 2025
0942865
refactor: apply prettier
axe312ger Sep 3, 2025
f5e33cd
ci: set proper latest node orb
axe312ger Sep 3, 2025
4f85938
typo...
axe312ger Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v18
v20
3 changes: 1 addition & 2 deletions .prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,4 @@ node_modules
dist
coverage
out
typings
rollup.config.js
typings
157 changes: 150 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 15 additions & 10 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,11 @@
"exports": {
".": {
"types": "./dist/types/index.d.ts",
"import": "./dist/esm/index.js",
"require": "./dist/cjs/index.cjs"
"node": "./dist/contentful-management.node.cjs",
"browser": "./dist/contentful-management.browser.cjs",
"react-native": "./dist/contentful-management.react-native.cjs",
"require": "./dist/cjs/index.cjs",
"default": "./dist/esm/index.js"
},
"./dist/contentful-management.node.cjs": "./dist/contentful-management.node.cjs",
"./dist/contentful-management.browser.js": "./dist/contentful-management.browser.js",
Expand All @@ -17,7 +20,7 @@
"main": "./dist/cjs/index.cjs",
"types": "dist/types/index.d.ts",
"engines": {
"node": ">=18"
"node": ">=20"
Copy link
Contributor

@elylucasctfl elylucasctfl Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets update the node used in CI here too https://github.com/contentful/contentful-management.js/blob/master/.circleci/config.yml#L10

Copy link
Collaborator Author

@axe312ger axe312ger Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!!

},
"browserslist": [
">0.3%",
Expand All @@ -34,16 +37,15 @@
"license": "MIT",
"scripts": {
"clean": "rimraf dist",
"build": "npm run clean && npm run build:esm && npm run build:rollup && rm -rf dist/esm-raw",
"build:esm": "tsc",
"build": "npm run clean && npm run build:rollup",
"build:rollup": "NODE_ENV=production rollup -c",
"build:docs": "typedoc",
"postbuild": "npm run check && npm run test:demo-projects",
"check": "npm run check:cjs && npm run check:esm && npm run check:browser && npm run check:browser-min",
"check:browser": "es-check es2018 ./dist/contentful-management.browser.js",
"check:browser-min": "es-check es2018 ./dist/contentful-management.browser.min.js",
"check:cjs": "es-check es2017 './dist/**/*.cjs'",
"check:esm": "es-check es2017 --module './dist/esm/*.js'",
"check:browser": "es-check es2021 ./dist/contentful-management.browser.js",
"check:browser-min": "es-check es2021 ./dist/contentful-management.browser.min.js",
"check:cjs": "es-check es2018 './dist/**/*.cjs'",
"check:esm": "es-check es2018 --module './dist/esm/*.js'",
"docs:dev": "npm run build && npm run build:docs",
"docs:watch": "nodemon --exec npm run docs:dev -w lib typings",
"docs:publish": "npm run build:docs && ./node_modules/contentful-sdk-jsdoc/bin/publish-docs.sh contentful-management.js contentful-management",
Expand Down Expand Up @@ -99,6 +101,7 @@
"@rollup/plugin-node-resolve": "^16.0.0",
"@rollup/plugin-replace": "^6.0.2",
"@rollup/plugin-terser": "^0.4.4",
"@rollup/plugin-typescript": "^12.1.4",
"@semantic-release/changelog": "^6.0.0",
"@size-limit/file": "^11.1.6",
"@types/json-patch": "^0.0.33",
Expand All @@ -119,10 +122,12 @@
"lodash": "^4.17.20",
"nodemon": "^3.1.2",
"playwright": "^1.49.1",
"prettier": "^2.6.0",
"prettier": "^3.6.2",
"process": "^0.11.10",
"rimraf": "^5.0.0",
"rollup": "^4.28.1",
"rollup-plugin-dts": "^6.2.3",
"rollup-plugin-sourcemaps": "^0.6.3",
"rollup-plugin-visualizer": "^5.12.0",
"semantic-release": "^22.0.12",
"size-limit": "^11.1.6",
Expand Down
Loading