Generate snapshots before testing

contentful-labs · Jan 29, 2018 · eb71fda · eb71fda
1 parent 8823a67
commit eb71fda
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 6 deletions.
diff --git a/Concorde.xcodeproj/xcshareddata/xcschemes/Concorde.xcscheme b/Concorde.xcodeproj/xcshareddata/xcschemes/Concorde.xcscheme
@@ -41,7 +41,7 @@
       selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
       selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
       language = ""
-      shouldUseLaunchSchemeArgsEnv = "YES">
+      shouldUseLaunchSchemeArgsEnv = "NO">
       <Testables>
          <TestableReference
             skipped = "NO">
@@ -63,6 +63,13 @@
             ReferencedContainer = "container:Concorde.xcodeproj">
          </BuildableReference>
       </MacroExpansion>
+      <EnvironmentVariables>
+         <EnvironmentVariable
+            key = "GENERATE_SNAPSHOTS"
+            value = "$(GENERATE_SNAPSHOTS)"
+            isEnabled = "YES">
+         </EnvironmentVariable>
+      </EnvironmentVariables>
       <AdditionalOptions>
       </AdditionalOptions>
    </TestAction>

diff --git a/Makefile b/Makefile
@@ -12,8 +12,14 @@ setup:
 	bundle exec pod install
 
 test:
+	bundle exec xcodebuild clean test \
+	 	-workspace Concorde.xcworkspace \
+		-scheme Concorde \
+		-destination "platform=iOS Simulator,name=iPhone 8 Plus" \
+		GENERATE_SNAPSHOTS=YES \
+		| xcpretty -c
 	bundle exec xcodebuild test \
 		-workspace Concorde.xcworkspace \
 		-scheme Concorde \
 		-destination 'platform=iOS Simulator,name=iPhone 8 Plus' \
-		| xcpretty -c
+		| xcpretty; exit ${PIPESTATUS[0]}
diff --git a/Tests/ConcordeTests.swift b/Tests/ConcordeTests.swift
@@ -10,8 +10,23 @@ import Concorde
 import Nimble
 import Nimble_Snapshots
 import Quick
+import Foundation
 
 class ConcordeTests: QuickSpec {
+
+    private func snapshotAction() -> Predicate<Snapshotable> {
+        guard let generateSnapshots = ProcessInfo.processInfo.environment["GENERATE_SNAPSHOTS"]?.lowercased() else {
+            return haveValidSnapshot()
+        }
+
+        switch generateSnapshots {
+        case "yes", "true", "1":
+            return recordSnapshot()
+        default:
+            return haveValidSnapshot()
+        }
+    }
+
     override func spec() {
         var crashData = Data()
         var nonProgressiveData = Data()
@@ -40,15 +55,15 @@ class ConcordeTests: QuickSpec {
             decoder?.decompress()
 
             let view = UIImageView(image: decoder?.toImage())
-            expect(view).to(haveValidSnapshot())
+            expect(view).to(self.snapshotAction())
         }
 
         it("can decode progressive JPEGs") {
             let decoder = CCBufferedImageDecoder(data: progressiveData)
             decoder?.decompress()
 
             let view = UIImageView(image: decoder?.toImage())
-            expect(view).to(haveValidSnapshot())
+            expect(view).to(self.snapshotAction())
         }
 
         it("can decode partial progressive JPEGs") {
@@ -57,7 +72,7 @@ class ConcordeTests: QuickSpec {
             decoder?.decompress()
 
             let view = UIImageView(image: decoder?.toImage())
-            expect(view).to(haveValidSnapshot())
+            expect(view).to(self.snapshotAction())
         }
 
         it("is resilient against errors in the data to decode") {
@@ -74,7 +89,7 @@ class ConcordeTests: QuickSpec {
             }
 
             let view = UIImageView(image: decoder?.toImage())
-            expect(view).to(haveValidSnapshot())
+            expect(view).to(self.snapshotAction())
         }
 
         it("is resilient against not calling decode() at all") {