refactor: use AsRef<Path> in load_jumbf_from_file()
#910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewhalle
force-pushed
the
andrewhalle/path
branch
from
771a77b to
c051a2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
While using this function, I noticed that it takes an explicit
&Path, which isn't as ergonomic as it could be. All of the functions instd::fsuseAsRef<Path>, which means that this function could easily take strings as well.&Pathis used a lot in this crate, and I didn't change any of the other occurrences. I'm happy to do so, just figured I would start the discussion with this PR.Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.