feat: Update c2patool to read CAWG data #907
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ci: Add debug statements * Omit additional paddings * feat: Omit more padding tags * ci: add explanation * ci: Catch result strings before they get returned * ci: sdk catch result string before returning them * ci: look into parsing stuff * ci: WIP for cawg display * ci: Replace signature with hash * ci: Replace signature with hash * ci: Clean up leftover debug code * ci: Parse cawg data in cli, introduce tokio * ci: WIP * ci: WIP * ci: Up some deps * ci: WIP * ci: WIP * feat: Add methods to reader to decorate the json * ci: Got the cleaned content signature * ci: Some clean up * ci: Some clean up * ci: WIP * feat: cawg parsing hack * feat: move display * feat: Refactor * feat: Refactor * feat: Refactor * ci: Tmp check all other tests * ci: Tmp check all other tests * Debug * fix: fix mistake of returning too early * fix: Remove debug file * fix: Remove debug file * fix: Change error handling
tmathern
commented
Feb 6, 2025
tmathern
force-pushed
the
mathern/cawg-reading-trois
branch
from
71cf103 to
cc6e7bd
Compare
tmathern
force-pushed
the
mathern/cawg-reading-trois
branch
from
1f0416c to
aba1ef6
Compare
scouten-adobe
requested changes
Feb 7, 2025
gpeacock
requested changes
Feb 7, 2025
feat: c2patool to read cawg data with `--detailed` flag too (#909)
tmathern
changed the title
tmathern
force-pushed
the
mathern/cawg-reading-trois
branch
from
5ab845e to
7d2418a
Compare
scouten-adobe
approved these changes
Feb 7, 2025
scouten-adobe
changed the title
gpeacock
reviewed
Feb 7, 2025
gpeacock
reviewed
Feb 7, 2025
| }; | ||
|
|
||
| let isv = IcaSignatureVerifier {}; | ||
| let ica_validated = tokio_runtime.block_on(identity_assertion.validate(manifest, &isv)); |
There was a problem hiding this comment.
we need to capture the validation results from this operation and add them to the rest of the validation results. Most of this logic belongs in CAWG.
There was a problem hiding this comment.
@scouten-adobe ^ FYI - for your APIS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c2patool file_with_cawg_data.extensionc2patool --detailed file_with_cawg_data.extension