Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cawg_identity): Split CredentialHolder into sync and async versions #891

Merged
merged 9 commits into from
Jan 30, 2025

Conversation

scouten-adobe
Copy link
Collaborator

No description provided.

@scouten-adobe scouten-adobe self-assigned this Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 86.19529% with 41 lines in your changes missing coverage. Please review.

Project coverage is 79.13%. Comparing base (0b9f122) to head (9f8bebb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ity/src/builder/async_identity_assertion_signer.rs 70.09% 32 Missing ⚠️
..._identity/src/builder/identity_assertion_signer.rs 69.56% 7 Missing ⚠️
...identity/src/builder/identity_assertion_builder.rs 98.48% 1 Missing ⚠️
sdk/src/signer.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #891      +/-   ##
==========================================
+ Coverage   78.96%   79.13%   +0.16%     
==========================================
  Files         143      144       +1     
  Lines       33978    34172     +194     
==========================================
+ Hits        26831    27041     +210     
+ Misses       7147     7131      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scouten-adobe scouten-adobe marked this pull request as ready for review January 30, 2025 19:07
@scouten-adobe scouten-adobe merged commit c820aa9 into main Jan 30, 2025
30 checks passed
@scouten-adobe scouten-adobe deleted the cawg+synchronous-sign branch January 30, 2025 19:15
@scouten-adobe scouten-adobe mentioned this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants