feat: Wasm32 wasi 0.41.0

[cdmurph32]

Changes in this pull request

feat: Add wasi compatibility.

• wasip2 will require +nightly until wasip2 target should not conditionally feature gate stdlib APIs rust-lang/rust#130323 is resolved and/or std::os::wasip2 is available in stable.
• Support was added to rustix for version 0.38.39 fix: enable wasip2 feature for wasm32-wasip2 target bytecodealliance/rustix#1205
• Support was added to tempfile for version 3.14 fix: enable wasip2 feature for wasm32-wasip2 target Stebalien/tempfile#305

Related issues:

• feat: Add tmp-dir WebAssembly/wasi-cli#54
• Conflicting imports of wasi cause wasm-component-ld error. bytecodealliance/wasm-tools#2047

Tests passing with WASI.
CARGO_TARGET_WASM32_WASIP2_RUNNER="wasmtime -S common -S http --dir ."

Checklist

• This PR represents a single feature, fix, or change.
• All applicable changes have been documented.
• Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.94%. Comparing base (49667a0) to head (3454987).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #888      +/-   ##
==========================================
+ Coverage   78.91%   78.94%   +0.02%     
==========================================
  Files         147      147              
  Lines       34827    34845      +18     
==========================================
+ Hits        27485    27507      +22     
+ Misses       7342     7338       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mauricefisher64]

How does this work for crypto? Does it use the new rust native path that we have for wasm?

[cdmurph32]

How does this work for crypto? Does it use the new rust native path that we have for wasm?

Yes. Removing WebCrypto made that very straightforward.

[mauricefisher64]

Does this code rely on the fact that the wasm target will bring in rust_native crypto? If so would it be better to just have a wasi target instead of a side effect. Otherwise this could be easily broken without someone knowing they are affecting wasi.

[cdmurph32]

Does this code rely on the fact that the wasm target will bring in rust_native crypto? If so would it be better to just have a wasi target instead of a side effect. Otherwise this could be easily broken without someone knowing they are affecting wasi.

The wasm32 target_arch covers all targets of that architecture, including wasm32-wasi. That target_arch is used intentionally .

[mauricefisher64]

Approved with comments