Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: X.509 support for CAWG identity SDK #880

Merged
merged 8 commits into from
Jan 25, 2025
Merged

feat: X.509 support for CAWG identity SDK #880

merged 8 commits into from
Jan 25, 2025

Conversation

scouten-adobe
Copy link
Collaborator

No description provided.

@scouten-adobe scouten-adobe self-assigned this Jan 23, 2025
@scouten-adobe scouten-adobe changed the title feat: Early version of X.509 support for CAWG identity SDK feat: X.509 support for CAWG identity SDK Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 89.79592% with 5 lines in your changes missing coverage. Please review.

Project coverage is 78.82%. Comparing base (0fccae9) to head (a1b350c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cawg_identity/src/x509/x509_signature_verifier.rs 81.48% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #880      +/-   ##
==========================================
+ Coverage   78.67%   78.82%   +0.15%     
==========================================
  Files         139      141       +2     
  Lines       32122    32171      +49     
==========================================
+ Hits        25271    25358      +87     
+ Misses       6851     6813      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scouten-adobe scouten-adobe marked this pull request as ready for review January 24, 2025 23:21
@scouten-adobe scouten-adobe merged commit 3a6a26b into main Jan 25, 2025
30 checks passed
@scouten-adobe scouten-adobe deleted the cawg+x509 branch January 25, 2025 00:10
@scouten-adobe scouten-adobe mentioned this pull request Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants