Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crypto): Make box_size parameter on c2pa_crypto::cose::sign an Option #879

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

scouten-adobe
Copy link
Collaborator

Signing via CAWG identity SDK for X.509 credentials does the padding at a different stage so I need to disable it here.

…an `Option`

Signing via CAWG identity SDK for X.509 credentials does the padding at a different stage so I need to disable it here.
@scouten-adobe scouten-adobe self-assigned this Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.67%. Comparing base (06c57a5) to head (db0f586).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/crypto/src/cose/sign.rs 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #879      +/-   ##
==========================================
- Coverage   78.67%   78.67%   -0.01%     
==========================================
  Files         139      139              
  Lines       32120    32122       +2     
==========================================
  Hits        25271    25271              
- Misses       6849     6851       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scouten-adobe scouten-adobe merged commit 00263a1 into main Jan 23, 2025
29 of 30 checks passed
@scouten-adobe scouten-adobe deleted the crypto-box-size-optional branch January 23, 2025 23:09
Copy link
Collaborator

@gpeacock gpeacock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you weren't a fan of Option parameters ;) I believe we still have copies of the cose signers in the c2pa-rs sdk. Perhaps it is time to just remove those, since a user could call the crypto versions directly. I'm not sure how that would impact our signer though.

@scouten-adobe
Copy link
Collaborator Author

@gpeacock I've stripped away some of those signers for common test cases, but some remain because the c2pa::Signer interface has things that aren't in (and shouldn't be in) the RawSigner interface.

@scouten-adobe scouten-adobe mentioned this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants