feat(crypto): Add rsa crate support to rust_native_crypto feature
#853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also makes RSA-PSS signatures available in WASM.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #853 +/- ##
==========================================
- Coverage 78.48% 78.15% -0.34%
==========================================
Files 136 139 +3
Lines 32049 32234 +185
==========================================
+ Hits 25154 25192 +38
- Misses 6895 7042 +147 ☔ View full report in Codecov by Sentry. |
| } | ||
|
|
||
| fn reserve_size(&self) -> usize { | ||
| 1024 + self.cert_chain_len + self.time_stamp_size |
There was a problem hiding this comment.
This should probably include OCSP size if part of this signer
There was a problem hiding this comment.
@mauricefisher64 do we have a way to estimate OCSP size ahead of time?
| @@ -62,21 +45,10 @@ pub(crate) fn async_validator_for_sig_and_hash_algs( | |||
| } else if hash_alg.as_ref() == SHA512_OID.as_bytes() { | |||
| return async_validator_for_signing_alg(SigningAlg::Es512); | |||
| } | |||
| } else if sig_alg.as_ref() == ED25519_OID.as_bytes() { | |||
There was a problem hiding this comment.
Ie ED25519 still supported
There was a problem hiding this comment.
Yes, it now goes through the rust_native path. The scope of webcrypto is now limited to what isn't (yet?) implemented in rust_native.
mauricefisher64
approved these changes
Jan 16, 2025
# Conflicts: # internal/crypto/src/raw_signature/webcrypto/check_certificate_trust.rs
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also makes RSA-PSS signatures available in WASM.