feat: SVG thumbnails with a fix to the ingredient thumbnail format detection #722
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Give a narrative description of what has been changed.
This adds the ability to correctly list an SVG as a thumbnail type for an asset. This would be useful in the font scenario, where using an SVG representation of the font is more efficient.
Additionally, it was noted that the logic in the
Ingredient::update_validation_status
and thethumbnail_from_assertion
calls were incorrectly assuming the extension would work for aformat!("image/{}", ext)
call. This was fine forjpg
and/orpng
, but forsvg
it should beimage/svg+xml
, so theutils::extension_to_mime
method was used in its stead.Checklist
TO DO
items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.