Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backed out calls to set_memory_thumbnail #243

Merged
merged 5 commits into from
May 2, 2023
Merged

Conversation

gpeacock
Copy link
Collaborator

@gpeacock gpeacock commented May 2, 2023

This was causing thumbnail files to not be generated.
Fixes CAI-3937, CAI-3942, CAI-3907

gpeacock added 2 commits May 2, 2023 15:53

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
This was causing thumbnail files to not be generated.
@gpeacock gpeacock requested review from dyro and mauricefisher64 May 2, 2023 23:16
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2023

Codecov Report

Merging #243 (ac45920) into main (28b6cb5) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
- Coverage   79.48%   79.40%   -0.08%     
==========================================
  Files          71       71              
  Lines       18993    18993              
==========================================
- Hits        15097    15082      -15     
- Misses       3896     3911      +15     
Impacted Files Coverage Δ
sdk/src/ingredient.rs 86.21% <100.00%> (-1.76%) ⬇️

@gpeacock gpeacock merged commit 3d3f7ca into main May 2, 2023
@gpeacock gpeacock deleted the gpeacock/revert_thumb_fix branch May 2, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants