Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Manifest::from_manifest_and_asset_bytes #127

Closed
wants to merge 1 commit into from

Conversation

gpeacock
Copy link
Collaborator

Changes in this pull request

Add Manifest::from_manifest_and_asset_bytes
For validating a remote manifest against asset bytes.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2022

Codecov Report

Merging #127 (914bc73) into main (58d527f) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   75.69%   75.77%   +0.07%     
==========================================
  Files          66       66              
  Lines       14588    14616      +28     
==========================================
+ Hits        11043    11075      +32     
+ Misses       3545     3541       -4     
Impacted Files Coverage Δ
sdk/src/manifest_store.rs 78.97% <100.00%> (-0.07%) ⬇️
make_test_images/src/make_test_images.rs 67.78% <0.00%> (-0.42%) ⬇️
sdk/src/store.rs 81.46% <0.00%> (+0.37%) ⬆️
sdk/src/cose_validator.rs 67.18% <0.00%> (+0.39%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@mauricefisher64 mauricefisher64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@dyro dyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gpeacock
Copy link
Collaborator Author

Closing this one as not necessary since we have the async version

@gpeacock gpeacock closed this Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants