Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1118 +/- ##
==========================================
+ Coverage 80.30% 80.82% +0.51%
==========================================
Files 153 143 -10
Lines 39323 38355 -968
==========================================
- Hits 31579 31001 -578
+ Misses 7744 7354 -390 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cdmurph32
force-pushed
the
openssl_feature2
branch
from
45d9730 to
ab56be6
Compare
3 tasks
cdmurph32
force-pushed
the
openssl_feature2
branch
4 times, most recently
from
8906876 to
56ee127
Compare
scouten-adobe
changed the title
scouten-adobe
requested changes
May 20, 2025
Collaborator
scouten-adobe
left a comment
scouten-adobe
left a comment
There was a problem hiding this comment.
Mostly 👍 but I have a concern about how values are passed between the GitHub Action steps.
Openssl will not be included when building rust native crypto
cdmurph32
force-pushed
the
openssl_feature2
branch
from
8031e0b to
201d970
Compare
cdmurph32
force-pushed
the
openssl_feature2
branch
from
201d970 to
d32184f
Compare
scouten-adobe
requested changes
May 20, 2025
Collaborator
scouten-adobe
left a comment
scouten-adobe
left a comment
There was a problem hiding this comment.
A couple minor things; otherwise 👍.
scouten-adobe
approved these changes
May 20, 2025
Merged
n8fr8
pushed a commit
to n8fr8/c2pa-rs
that referenced
this pull request
May 22, 2025
Openssl will not be included when building rust native crypto --------- Co-authored-by: Eric Scouten <scouten@adobe.com>
Merged
gpeacock
pushed a commit
that referenced
this pull request
Dec 16, 2025
Openssl will not be included when building rust native crypto --------- Co-authored-by: Eric Scouten <scouten@adobe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Openssl will not be included when building rust native crypto
CI tests for both openssl and rust_native_crypto features
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.