fix: Make alg enum exhaustive (#866)

* fix: Make alg enum exhaustive again * fix: update tests with exhaustive checks
contentauth · Jan 22, 2025 · 0466948 · 0466948
1 parent 06fc905
commit 0466948
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 5 deletions.
diff --git a/cawg_identity/src/tests/fixtures/test_credentials.rs b/cawg_identity/src/tests/fixtures/test_credentials.rs
@@ -49,7 +49,5 @@ pub(crate) fn cert_chain_and_private_key_for_alg(alg: SigningAlg) -> (Vec<u8>, V
             include_bytes!("../../../../sdk/tests/fixtures/certs/ed25519.pub").to_vec(),
             include_bytes!("../../../../sdk/tests/fixtures/certs/ed25519.pem").to_vec(),
         ),
-
-        _ => unimplemented!("Unknown SigningAlg variant {alg:#?}"),
     }
 }
diff --git a/internal/crypto/src/raw_signature/signing_alg.rs b/internal/crypto/src/raw_signature/signing_alg.rs
@@ -28,7 +28,6 @@ use serde::{Deserialize, Serialize};
 /// [§13.2, “Digital Signatures”]: https://c2pa.org/specifications/specifications/2.1/specs/C2PA_Specification.html#_digital_signatures
 #[derive(Copy, Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
 #[cfg_attr(feature = "json_schema", derive(JsonSchema))]
-#[non_exhaustive]
 pub enum SigningAlg {
     /// ECDSA with SHA-256
     Es256,

diff --git a/sdk/src/utils/test_signer.rs b/sdk/src/utils/test_signer.rs
@@ -87,8 +87,6 @@ fn cert_chain_and_private_key_for_alg(alg: SigningAlg) -> (Vec<u8>, Vec<u8>) {
             include_bytes!("../../tests/fixtures/certs/ed25519.pub").to_vec(),
             include_bytes!("../../tests/fixtures/certs/ed25519.pem").to_vec(),
         ),
-
-        _ => unimplemented!("Unknown SigningAlg variant {alg:#?}"),
     }
 }
-Original file line number
+Diff line change
@@ Expand Up @@
                 include_bytes!("../../tests/fixtures/certs/ed25519.pub").to_vec(),
                 include_bytes!("../../tests/fixtures/certs/ed25519.pem").to_vec(),
             ),
-            _ => unimplemented!("Unknown SigningAlg variant {alg:#?}"),
         }
     }
@@ Expand Down @@