Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react keys #258

Merged
merged 2 commits into from
Apr 5, 2022
Merged

react keys #258

merged 2 commits into from
Apr 5, 2022

Conversation

JanTvrdik
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Apr 5, 2022 •
edited
Loading

Playwright Test Report

matej21
matej21 requested changes Apr 5, 2022
View reviewed changes
Copy link
Member

@matej21 matej21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please enable fragments check:

"react/jsx-key": ['error', {"checkFragmentShorthand": true }],

@matej21
Copy link
Member

matej21 commented Apr 5, 2022

Unfortunatelly, it does not handle conditions properly: jsx-eslint/eslint-plugin-react#3117

@JanTvrdik JanTvrdik enabled auto-merge April 5, 2022 14:50
@JanTvrdik JanTvrdik requested a review from matej21 April 5, 2022 15:02
@JanTvrdik JanTvrdik disabled auto-merge April 5, 2022 15:02
@JanTvrdik JanTvrdik merged commit d6c6068 into main Apr 5, 2022
@JanTvrdik JanTvrdik deleted the pr/react-keys branch April 5, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matej21 matej21 Awaiting requested review from matej21

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JanTvrdik @matej21