Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use default http transport for head #926

Merged
merged 1 commit into from
Apr 24, 2021
Merged

Conversation

piksel
Copy link
Member

@piksel piksel commented Apr 24, 2021

Restore default http transport settings, including proxy auto-detection for HEAD requests.

Fixes #922

@codecov
Copy link

codecov bot commented Apr 24, 2021

Codecov Report

Merging #926 (98e5199) into main (b4cf17d) will increase coverage by 6.21%.
The diff coverage is 15.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #926      +/-   ##
==========================================
+ Coverage   40.14%   46.35%   +6.21%     
==========================================
  Files          25       25              
  Lines        1415     1426      +11     
==========================================
+ Hits          568      661      +93     
+ Misses        785      697      -88     
- Partials       62       68       +6     
Impacted Files Coverage Δ
pkg/registry/digest/digest.go 0.00% <0.00%> (ø)
pkg/notifications/shoutrrr.go 73.43% <100.00%> (+0.42%) ⬆️
pkg/notifications/email.go 90.90% <0.00%> (+4.54%) ⬆️
pkg/container/client.go 18.45% <0.00%> (+18.45%) ⬆️
pkg/container/container.go 36.70% <0.00%> (+36.70%) ⬆️
pkg/container/metadata.go 63.63% <0.00%> (+63.63%) ⬆️
pkg/container/util.go 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d38e52b...98e5199. Read the comment docs.

@piksel piksel merged commit fdf6e46 into main Apr 24, 2021
@piksel piksel deleted the fix/head-http-transport branch April 24, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image digest HEAD checking does not respect proxy settings
1 participant