Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set nopull param from args #1830

Merged
merged 2 commits into from
Nov 11, 2023
Merged

fix: set nopull param from args #1830

merged 2 commits into from
Nov 11, 2023

Conversation

piksel
Copy link
Member

@piksel piksel commented Nov 11, 2023

Fixes the no-pull arg not being forwarded to the update params. Also removes the leftovers (ClientOptions.PullImages) that prevented this problem from showing up in the lint.

Fixes #1819

this also fully removes `PullImages` from the client options
as it is no longer used.
@piksel piksel requested a review from simskij as a code owner November 11, 2023 13:32
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (72e437f) 69.23% compared to head (fb13af4) 70.63%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1830      +/-   ##
==========================================
+ Coverage   69.23%   70.63%   +1.39%     
==========================================
  Files          26       26              
  Lines        2467     2489      +22     
==========================================
+ Hits         1708     1758      +50     
+ Misses        661      631      -30     
- Partials       98      100       +2     
Files Coverage Δ
pkg/container/client.go 50.12% <ø> (ø)
pkg/notifications/shoutrrr.go 73.91% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@piksel piksel merged commit 48539c4 into main Nov 11, 2023
11 checks passed
@piksel piksel deleted the fix/no-pull branch November 11, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: --no-pull flag is ignored
1 participant